This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
Larger y-axis transfer time range for more eccentric orbits #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, let me say this is a great tool! Thanks for making it!
I was using it with custom vessels in Kerbol orbit to find the best burn to get a planetary fly-by, and I found that sometimes the best burn would actually be a shorter transit time than what the default plot shows. The pork chop was completely correct, but the axes didn't include the best burn. I know the "Time of flight" range can be adjusted in the advanced settings, but I was curious why the default range was wrong.
The default values for the y-axis range were being generated using the Hohmann transfer time as a guide. However the Hohmann transfer time was calculated only using semi-major axis lengths of the two orbits. But for eccentric orbits the Hohmann transfer time could be quite a bit less. In fact, sometimes the origin orbit can overlap with the destination orbit (obviously this can only happen for custom vessel orbits), meaning there's no lower bound on transit time. There might even be an intercept/collision in the future with 0m/s of burn.
For journeys between planets and moons the y-axis range is only very slightly changed by this commit, due to low eccentricity of planet/moon orbits. The difference only comes in for vessel orbits. I have the modified version hosted at https://andyborrell.github.io/ksp if you would like to test.
See here for an example of a mission profile which has a better default range with this change: https://imgur.com/a/WinrhOC